Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loads the sessions by pages of 10, instead of loading the whole list immediately.
This is meant to look at how the Apollo Kotlin pagination system can be implemented in a real project.
Caveat: the pages are based on the contents of the list: when getting the first few items, we only know about Day 1, and only when scrolling to the end of Day 1 do we know that there's a Day 2, and the pager gets updated. Because of this, this can't be merged and I'll close the PR right now - at least it's a reference at how to use the pagination system that will be in the PR history.
The steps were:
extra.graphqls2.1 mark
sessionsas embedded2.2 mark
sessions.firstand.afteras pagination args2.3 mark
pageInfoas embeddedMetaDataGeneratorto keep track ofendCursorandafterFieldMergerto merge thenodeslistsfetchNextSessionsPagefun and call it from the UI when reaching the end of the LazyColumnNote: steps 2-4 would have been simpler if the schema were following the Relay pagination spec - the rest would have been the same.
pagination.webm